Checkstyle Results

The following document contains the results of Checkstyle 6.16 with odl_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
15 0 89 0

Files

File  I  W  E
org/opendaylight/netvirt/openstack/sfc/translator/DelegatingDataTreeListener.java 0 7 0
org/opendaylight/netvirt/openstack/sfc/translator/INeutronSfcDataProcessor.java 0 2 0
org/opendaylight/netvirt/openstack/sfc/translator/NeutronMdsalHelper.java 0 5 0
org/opendaylight/netvirt/openstack/sfc/translator/OvsdbMdsalHelper.java 0 6 0
org/opendaylight/netvirt/openstack/sfc/translator/SfcMdsalHelper.java 0 3 0
org/opendaylight/netvirt/openstack/sfc/translator/flowclassifier/FlowClassifierTranslator.java 0 4 0
org/opendaylight/netvirt/openstack/sfc/translator/flowclassifier/NeutronFlowClassifierListener.java 0 3 0
org/opendaylight/netvirt/openstack/sfc/translator/portchain/NeutronPortChainListener.java 0 20 0
org/opendaylight/netvirt/openstack/sfc/translator/portchain/NeutronPortPairGroupListener.java 0 3 0
org/opendaylight/netvirt/openstack/sfc/translator/portchain/NeutronPortPairListener.java 0 5 0
org/opendaylight/netvirt/openstack/sfc/translator/portchain/PortChainTranslator.java 0 5 0
org/opendaylight/netvirt/openstack/sfc/translator/portchain/PortPairGroupTranslator.java 0 15 0
org/opendaylight/netvirt/openstack/sfc/translator/portchain/PortPairTranslator.java 0 11 0

Rules

Category Rule Violations Severity
coding IllegalCatch 2  Warning
VariableDeclarationUsageDistance 10  Warning
imports CustomImportOrder
  • thirdPartyPackageRegExp: ".*"
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###THIRD_PARTY_PACKAGE"
 28  Warning
indentation Indentation
  • throwsIndent: "4"
  • arrayInitIndent: "4"
  • caseIndent: "4"
  • basicOffset: "4"
  • braceAdjustment: "0"
  • lineWrappingIndentation: "4"
 2  Warning
javadoc JavadocStyle
  • checkEmptyJavadoc: "true"
 5  Warning
naming ConstantName 12  Warning
sizes LineLength
  • max: "120"
  • ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
 4  Warning
whitespace EmptyLineSeparator
  • allowNoEmptyLineBetweenFields: "true"
  • tokens: "IMPORT, CLASS_DEF, INTERFACE_DEF, ENUM_DEF, STATIC_INIT, INSTANCE_INIT, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"
 3  Warning
OperatorWrap
  • tokens: "BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "
  • option: "NL"
 5  Warning
WhitespaceAround
  • allowEmptyConstructors: "true"
  • allowEmptyMethods: "true"
  • allowEmptyLoops: "true"
  • allowEmptyTypes: "true"
 13  Warning

Details

org/opendaylight/netvirt/openstack/sfc/translator/DelegatingDataTreeListener.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'javax.annotation.Nonnull' import. Should be before 'org.slf4j.LoggerFactory'. 24
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.Collection' import. Should be before 'org.slf4j.LoggerFactory'. 25
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.concurrent.ExecutorService' import. Should be before 'org.slf4j.LoggerFactory'. 26
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.concurrent.Executors' import. Should be before 'org.slf4j.LoggerFactory'. 27
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.concurrent.ThreadFactory' import. Should be before 'org.slf4j.LoggerFactory'. 28
 Warning naming ConstantName Name 'threadFactory' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 37
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 53

org/opendaylight/netvirt/openstack/sfc/translator/INeutronSfcDataProcessor.java

Severity Category Rule Message Line
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 14
 Warning javadoc JavadocStyle First sentence should end with a period. 14

org/opendaylight/netvirt/openstack/sfc/translator/NeutronMdsalHelper.java

Severity Category Rule Message Line
 Warning naming ConstantName Name 'fcIid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 37
 Warning naming ConstantName Name 'portsIid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 39
 Warning naming ConstantName Name 'portPairsIid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 41
 Warning naming ConstantName Name 'portPairGroupsIid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 43
 Warning sizes LineLength Line is longer than 120 characters (found 122). 73

org/opendaylight/netvirt/openstack/sfc/translator/OvsdbMdsalHelper.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. 30
 Warning naming ConstantName Name 'topologyPath' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 38
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 60
 Warning whitespace WhitespaceAround WhitespaceAround: 'if' is not followed by whitespace. 75
 Warning whitespace OperatorWrap '+' should be on a new line. 92
 Warning whitespace WhitespaceAround WhitespaceAround: 'if' is not followed by whitespace. 103

org/opendaylight/netvirt/openstack/sfc/translator/SfcMdsalHelper.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. 34
 Warning sizes LineLength Line is longer than 120 characters (found 124). 181
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 184

org/opendaylight/netvirt/openstack/sfc/translator/flowclassifier/FlowClassifierTranslator.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.slf4j.LoggerFactory'. 38
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 53
 Warning coding VariableDeclarationUsageDistance Distance between variable 'accessListEntriesBuilder' declaration and its first usage is 19, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 56
 Warning coding VariableDeclarationUsageDistance Distance between variable 'matchesBuilder' declaration and its first usage is 13, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 58

org/opendaylight/netvirt/openstack/sfc/translator/flowclassifier/NeutronFlowClassifierListener.java

Severity Category Rule Message Line
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 21
 Warning javadoc JavadocStyle First sentence should end with a period. 21
 Warning naming ConstantName Name 'flowClassifiersIid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 26

org/opendaylight/netvirt/openstack/sfc/translator/portchain/NeutronPortChainListener.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.slf4j.LoggerFactory'. 45
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.HashMap' import. Should be before 'org.slf4j.LoggerFactory'. 46
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. 47
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.Map' import. Should be before 'org.slf4j.LoggerFactory'. 48
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.concurrent.ExecutionException' import. Should be before 'org.slf4j.LoggerFactory'. 49
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.concurrent.ExecutorService' import. Should be before 'org.slf4j.LoggerFactory'. 50
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.concurrent.Executors' import. Should be before 'org.slf4j.LoggerFactory'. 51
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.concurrent.Future' import. Should be before 'org.slf4j.LoggerFactory'. 52
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.concurrent.ThreadFactory' import. Should be before 'org.slf4j.LoggerFactory'. 53
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 55
 Warning javadoc JavadocStyle First sentence should end with a period. 55
 Warning naming ConstantName Name 'portChainIid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 61
 Warning whitespace WhitespaceAround WhitespaceAround: 'if' is not followed by whitespace. 87
 Warning whitespace WhitespaceAround WhitespaceAround: 'for' is not followed by whitespace. 150
 Warning whitespace WhitespaceAround WhitespaceAround: 'for' is not followed by whitespace. 170
 Warning whitespace WhitespaceAround WhitespaceAround: 'if' is not followed by whitespace. 176
 Warning whitespace WhitespaceAround WhitespaceAround: 'if' is not followed by whitespace. 203
 Warning indentation Indentation 'if' child have incorrect indentation level 11, expected level should be 12. 261
 Warning sizes LineLength Line is longer than 120 characters (found 121). 289
 Warning whitespace OperatorWrap '+' should be on a new line. 305

org/opendaylight/netvirt/openstack/sfc/translator/portchain/NeutronPortPairGroupListener.java

Severity Category Rule Message Line
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 19
 Warning javadoc JavadocStyle First sentence should end with a period. 19
 Warning naming ConstantName Name 'portPairGroupIid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 23

org/opendaylight/netvirt/openstack/sfc/translator/portchain/NeutronPortPairListener.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. 31
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 33
 Warning javadoc JavadocStyle First sentence should end with a period. 33
 Warning naming ConstantName Name 'portPairIid' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 39
 Warning whitespace OperatorWrap '+' should be on a new line. 95

org/opendaylight/netvirt/openstack/sfc/translator/portchain/PortChainTranslator.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.slf4j.LoggerFactory'. 32
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. 33
 Warning whitespace WhitespaceAround WhitespaceAround: 'for' is not followed by whitespace. 56
 Warning whitespace WhitespaceAround WhitespaceAround: 'if' is not followed by whitespace. 68
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 104

org/opendaylight/netvirt/openstack/sfc/translator/portchain/PortPairGroupTranslator.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.slf4j.LoggerFactory'. 47
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.Iterator' import. Should be before 'org.slf4j.LoggerFactory'. 48
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. 49
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.Map' import. Should be before 'org.slf4j.LoggerFactory'. 50
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.concurrent.atomic.AtomicInteger' import. Should be before 'org.slf4j.LoggerFactory'. 51
 Warning naming ConstantName Name 'counter' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 63
 Warning coding VariableDeclarationUsageDistance Distance between variable 'sffOvsBridgeAugBuilder' declaration and its first usage is 8, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 75
 Warning coding VariableDeclarationUsageDistance Distance between variable 'sffDataPlaneLocator' declaration and its first usage is 13, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 78
 Warning coding VariableDeclarationUsageDistance Distance between variable 'sffDplBuilder' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 79
 Warning indentation Indentation 'if' child have incorrect indentation level 11, expected level should be 12. 88
 Warning whitespace OperatorWrap '+' should be on a new line. 88
 Warning whitespace WhitespaceAround WhitespaceAround: 'if' is not followed by whitespace. 121
 Warning coding VariableDeclarationUsageDistance Distance between variable 'sfdList' declaration and its first usage is 7, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 159
 Warning sizes LineLength Line is longer than 120 characters (found 121). 178
 Warning coding VariableDeclarationUsageDistance Distance between variable 'ovsOptions' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 196

org/opendaylight/netvirt/openstack/sfc/translator/portchain/PortPairTranslator.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.slf4j.LoggerFactory'. 43
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. 44
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.concurrent.atomic.AtomicInteger' import. Should be before 'org.slf4j.LoggerFactory'. 45
 Warning naming ConstantName Name 'counter' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 65
 Warning coding VariableDeclarationUsageDistance Distance between variable 'sfDataPlaneLocatorList' declaration and its first usage is 14, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 80
 Warning coding VariableDeclarationUsageDistance Distance between variable 'sfDataPlaneLocatorBuilder' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 81
 Warning coding VariableDeclarationUsageDistance Distance between variable 'sfParams' declaration and its first usage is 11, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 84
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 111
 Warning whitespace OperatorWrap '+' should be on a new line. 139
 Warning whitespace WhitespaceAround WhitespaceAround: 'for' is not followed by whitespace. 145
 Warning whitespace WhitespaceAround WhitespaceAround: 'if' is not followed by whitespace. 176