FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is low
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 25 |
13 |
0 |
0 |
org.opendaylight.netvirt.openstack.sfc.translator.DelegatingDataTreeListener
| Bug |
Category |
Details |
Line |
Priority |
| Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in org.opendaylight.netvirt.openstack.sfc.translator.DelegatingDataTreeListener.onDataTreeChanged(Collection) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
89 |
Low |
org.opendaylight.netvirt.openstack.sfc.translator.OpenStackSFCTranslatorProvider
| Bug |
Category |
Details |
Line |
Priority |
| Write to static field org.opendaylight.netvirt.openstack.sfc.translator.OpenStackSFCTranslatorProvider.bundleContext from instance method new org.opendaylight.netvirt.openstack.sfc.translator.OpenStackSFCTranslatorProvider(DataBroker, RenderedServicePathService, OpenstackSfcTranslatorConfig, BundleContext) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
38 |
High |
org.opendaylight.netvirt.openstack.sfc.translator.OvsdbMdsalHelper
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference of bridgeAugmentation in org.opendaylight.netvirt.openstack.sfc.translator.OvsdbMdsalHelper.getOvsdbPortMetadata(Uuid, Topology) |
CORRECTNESS |
NP_NULL_ON_SOME_PATH |
99 |
Medium |
org.opendaylight.netvirt.openstack.sfc.translator.flowclassifier.FlowClassifierTranslator
| Bug |
Category |
Details |
Line |
Priority |
| Useless control flow in org.opendaylight.netvirt.openstack.sfc.translator.flowclassifier.FlowClassifierTranslator.buildAcl(SfcFlowClassifier, String) |
STYLE |
UCF_USELESS_CONTROL_FLOW |
127 |
Low |
org.opendaylight.netvirt.openstack.sfc.translator.portchain.NeutronPortChainListener
| Bug |
Category |
Details |
Line |
Priority |
| Null passed for non-null parameter of PortChainTranslator.buildServiceFunctionPath(ServiceFunctionChain) in org.opendaylight.netvirt.openstack.sfc.translator.portchain.NeutronPortChainListener.processPortChain(PortChain) |
CORRECTNESS |
NP_NULL_PARAM_DEREF |
257 |
High |
| Redundant nullcheck of sfBuilder, which is known to be non-null in org.opendaylight.netvirt.openstack.sfc.translator.portchain.NeutronPortChainListener.processPortChain(PortChain) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
220 |
Medium |
| Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in org.opendaylight.netvirt.openstack.sfc.translator.portchain.NeutronPortChainListener.add(InstanceIdentifier, PortChain) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
122 |
Low |
| Useless object stored in variable portPairGroupToSFFMap of method org.opendaylight.netvirt.openstack.sfc.translator.portchain.NeutronPortChainListener.processPortChain(PortChain) |
STYLE |
UC_USELESS_OBJECT |
141 |
Medium |
org.opendaylight.netvirt.openstack.sfc.translator.portchain.PortChainTranslator
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.netvirt.openstack.sfc.translator.portchain.PortChainTranslator.buildServiceFunctionChain(PortChain, List) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead |
PERFORMANCE |
DM_BOOLEAN_CTOR |
70 |
Medium |
org.opendaylight.netvirt.openstack.sfc.translator.portchain.PortPairTranslator
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.netvirt.openstack.sfc.translator.portchain.PortPairTranslator.buildServiceFunction(PortPair, PortPairGroup, Port, OvsdbPortMetadata, ServiceFunctionForwarder) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead |
PERFORMANCE |
DM_BOOLEAN_CTOR |
147 |
Medium |
| org.opendaylight.netvirt.openstack.sfc.translator.portchain.PortPairTranslator.buildServiceFunction(PortPair, PortPairGroup, Port, OvsdbPortMetadata, ServiceFunctionForwarder) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
163 |
Medium |
| Nullcheck of neutronPort at line 107 of value previously dereferenced in org.opendaylight.netvirt.openstack.sfc.translator.portchain.PortPairTranslator.buildServiceFunction(PortPair, PortPairGroup, Port, OvsdbPortMetadata, ServiceFunctionForwarder) |
CORRECTNESS |
RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE |
76 |
High |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.openstack.sfc.translator.config.rev160720.OpenstackSfcTranslatorConfigBuilder$OpenstackSfcTranslatorConfigImpl
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.openstack.sfc.translator.config.rev160720.OpenstackSfcTranslatorConfigBuilder$OpenstackSfcTranslatorConfigImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.openstack.sfc.translator.config.rev160720.OpenstackSfcTranslatorConfigBuilder$OpenstackSfcTranslatorConfigImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
141 |
Low |
