Checkstyle Results

The following document contains the results of Checkstyle 6.2 with odl_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
3 0 138 0

Files

File  I  W  E
org/opendaylight/topology/mlmt/observer/AbstractMlmtTopologyObserver.java 0 128 0
org/opendaylight/topology/mlmt/observer/MlmtDataChangeEventListener.java 0 6 0
org/opendaylight/topology/mlmt/observer/MlmtTopologyObserver.java 0 4 0

Rules

Category Rule Violations Severity
blocks RightCurly
  • tokens: "CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"
  • option: "alone"
 4  Warning
RightCurly 4  Warning
imports CustomImportOrder
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###STANDARD_JAVA_PACKAGE###THIRD_PARTY_PACKAGE###SPECIAL_IMPORTS"
  • thirdPartyPackageRegExp: ".*"
  • specialImportsRegExp: "^com.*"
 22  Warning
indentation Indentation
  • lineWrappingIndentation: "4"
  • caseIndent: "4"
  • arrayInitIndent: "4"
  • throwsIndent: "4"
  • basicOffset: "4"
  • braceAdjustment: "0"
 54  Warning
javadoc JavadocMethod
  • allowMissingParamTags: "true"
  • allowedAnnotations: "Override, Test"
  • allowThrowsTagsForSubclasses: "true"
  • scope: "public"
  • allowMissingReturnTag: "true"
  • minLineCount: "2"
  • allowMissingThrowsTags: "true"
 2  Warning
naming LocalVariableName
  • allowOneCharVarInForLoop: "true"
  • tokens: "VARIABLE_DEF"
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
 13  Warning
ParameterName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
 3  Warning
sizes LineLength
  • max: "120"
  • ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
 7  Warning
whitespace EmptyLineSeparator
  • allowNoEmptyLineBetweenFields: "true"
 1  Warning
MethodParamPad 1  Warning
OperatorWrap
  • tokens: "BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "
  • option: "NL"
 28  Warning
WhitespaceAround
  • allowEmptyLoops: "true"
  • allowEmptyTypes: "true"
  • allowEmptyMethods: "true"
  • allowEmptyConstructors: "true"
 3  Warning

Details

org/opendaylight/topology/mlmt/observer/AbstractMlmtTopologyObserver.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.List' import. 13
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.Set' import. 16
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.DataChangeListener' import. 23
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.DataBroker' import. 25
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction' import. 27
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.NodeId' import. 31
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.TopologyTypes' import. 33
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.Topology' import. 34
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Link' import. 40
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.LinkId' import. 42
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.topology.mlmt.utility.MlmtTopologyProvider' import. 43
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.topology.mlmt.utility.MlmtTopologyBuilder' import. 44
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.topology.mlmt.utility.MlmtProviderFactory' import. 45
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.topology.mlmt.utility.MlmtConsequentAction' import. 46
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yangtools.yang.binding.DataObject' import. 50
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 101
 Warning naming LocalVariableName Local variable name 'lNode' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 109
 Warning naming LocalVariableName Local variable name 'lLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 110
 Warning indentation Indentation 'for' child have incorrect indentation level 19, expected level should be 20. 116
 Warning indentation Indentation 'method call' child have incorrect indentation level 19, expected level should be 20. 116
 Warning naming LocalVariableName Local variable name 'lTp' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 118
 Warning indentation Indentation 'for' have incorrect indentation level 19, expected level should be 16. 131
 Warning indentation Indentation 'for' child have incorrect indentation level 23, expected level should be 20. 132
 Warning sizes LineLength Line is longer than 120 characters (found 126). 140
 Warning naming LocalVariableName Local variable name 'lNode' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 141
 Warning naming LocalVariableName Local variable name 'lLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 142
 Warning naming LocalVariableName Local variable name 'lTp' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 147
 Warning indentation Indentation 'if' child have incorrect indentation level 13, expected level should be 12. 171
 Warning indentation Indentation 'if' child have incorrect indentation level 13, expected level should be 12. 173
 Warning indentation Indentation 'if' child have incorrect indentation level 13, expected level should be 12. 174
 Warning naming LocalVariableName Local variable name 'lUnderlay' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 188
 Warning naming LocalVariableName Local variable name 'r' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 193
 Warning naming LocalVariableName Local variable name 'm' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 194
 Warning sizes LineLength Line is longer than 120 characters (found 130). 219
 Warning whitespace MethodParamPad '(' is preceded with whitespace. 225
 Warning naming LocalVariableName Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 230
 Warning whitespace OperatorWrap '+' should be on a new line. 235
 Warning blocks RightCurly '}' should be on the same line. 239
 Warning whitespace OperatorWrap '+' should be on a new line. 245
 Warning indentation Indentation 'catch' child have incorrect indentation level 10, expected level should be 12. 252
 Warning indentation Indentation 'method call' child have incorrect indentation level 10, expected level should be 12. 252
 Warning indentation Indentation 'catch' child have incorrect indentation level 10, expected level should be 12. 254
 Warning indentation Indentation 'method call' child have incorrect indentation level 10, expected level should be 12. 254
 Warning whitespace OperatorWrap '+' should be on a new line. 263
 Warning blocks RightCurly '}' should be on the same line. 271
 Warning whitespace OperatorWrap '+' should be on a new line. 285
 Warning blocks RightCurly '}' should be on the same line. 291
 Warning whitespace OperatorWrap '+' should be on a new line. 303
 Warning blocks RightCurly '}' should be on the same line. 309
 Warning sizes LineLength Line is longer than 120 characters (found 121). 319
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 330
 Warning whitespace OperatorWrap '+' should be on a new line. 330
 Warning indentation Indentation 'member def type' have incorrect indentation level 9, expected level should be 8. 332
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 332
 Warning indentation Indentation 'if' have incorrect indentation level 9, expected level should be 8. 333
 Warning indentation Indentation 'if' child have incorrect indentation level 13, expected level should be 12. 334
 Warning indentation Indentation 'member def type' have incorrect indentation level 13, expected level should be 12. 334
 Warning indentation Indentation 'if' child have incorrect indentation level 13, expected level should be 12. 335
 Warning indentation Indentation 'if' child have incorrect indentation level 13, expected level should be 12. 337
 Warning whitespace OperatorWrap '+' should be on a new line. 347
 Warning whitespace OperatorWrap '+' should be on a new line. 362
 Warning sizes LineLength Line is longer than 120 characters (found 123). 375
 Warning sizes LineLength Line is longer than 120 characters (found 131). 382
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 389
 Warning whitespace OperatorWrap '+' should be on a new line. 389
 Warning indentation Indentation 'for' have incorrect indentation level 9, expected level should be 8. 391
 Warning indentation Indentation 'for' child have incorrect indentation level 13, expected level should be 12. 392
 Warning indentation Indentation 'for rcurly' have incorrect indentation level 9, expected level should be 8. 393
 Warning indentation Indentation 'member def type' have incorrect indentation level 9, expected level should be 8. 394
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 394
 Warning indentation Indentation 'if' have incorrect indentation level 9, expected level should be 8. 395
 Warning indentation Indentation 'if' child have incorrect indentation level 13, expected level should be 12. 396
 Warning indentation Indentation 'if rcurly' have incorrect indentation level 9, expected level should be 8. 397
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 403
 Warning whitespace OperatorWrap '+' should be on a new line. 403
 Warning indentation Indentation 'for' have incorrect indentation level 9, expected level should be 8. 405
 Warning indentation Indentation 'for' child have incorrect indentation level 13, expected level should be 12. 406
 Warning indentation Indentation 'for rcurly' have incorrect indentation level 9, expected level should be 8. 407
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 408
 Warning whitespace OperatorWrap '+' should be on a new line. 414
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 422
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 425
 Warning naming LocalVariableName Local variable name 'd' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 429
 Warning indentation Indentation 'catch' child have incorrect indentation level 15, expected level should be 16. 434
 Warning indentation Indentation 'method call' child have incorrect indentation level 15, expected level should be 16. 434
 Warning indentation Indentation 'catch' child have incorrect indentation level 15, expected level should be 16. 436
 Warning indentation Indentation 'method call' child have incorrect indentation level 15, expected level should be 16. 436
 Warning indentation Indentation 'catch' child have incorrect indentation level 15, expected level should be 16. 438
 Warning indentation Indentation 'method call' child have incorrect indentation level 15, expected level should be 16. 438
 Warning indentation Indentation 'while rcurly' have incorrect indentation level 9, expected level should be 8. 440
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 441
 Warning indentation Indentation 'method def rcurly' have incorrect indentation level 5, expected level should be 4. 442
 Warning naming ParameterName Parameter name 'c' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 448
 Warning whitespace OperatorWrap '+' should be on a new line. 467
 Warning whitespace OperatorWrap '+' should be on a new line. 472
 Warning whitespace OperatorWrap '+' should be on a new line. 478
 Warning whitespace OperatorWrap '+' should be on a new line. 479
 Warning indentation Indentation 'if' child have incorrect indentation level 21, expected level should be 20. 482
 Warning indentation Indentation 'member def modifier' have incorrect indentation level 21, expected level should be 20. 482
 Warning indentation Indentation 'if' child have incorrect indentation level 21, expected level should be 20. 483
 Warning indentation Indentation 'member def modifier' have incorrect indentation level 21, expected level should be 20. 483
 Warning indentation Indentation 'if' child have incorrect indentation level 21, expected level should be 20. 484
 Warning whitespace OperatorWrap '+' should be on a new line. 484
 Warning whitespace OperatorWrap '+' should be on a new line. 490
 Warning whitespace OperatorWrap '+' should be on a new line. 491
 Warning whitespace OperatorWrap '+' should be on a new line. 496
 Warning naming ParameterName Parameter name 'c' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 508
 Warning whitespace OperatorWrap '+' should be on a new line. 521
 Warning whitespace OperatorWrap '+' should be on a new line. 522
 Warning indentation Indentation 'if' child have incorrect indentation level 21, expected level should be 20. 525
 Warning indentation Indentation 'member def modifier' have incorrect indentation level 21, expected level should be 20. 525
 Warning indentation Indentation 'if' child have incorrect indentation level 21, expected level should be 20. 526
 Warning indentation Indentation 'member def modifier' have incorrect indentation level 21, expected level should be 20. 526
 Warning indentation Indentation 'if' child have incorrect indentation level 21, expected level should be 20. 527
 Warning whitespace OperatorWrap '+' should be on a new line. 527
 Warning whitespace OperatorWrap '+' should be on a new line. 532
 Warning whitespace OperatorWrap '+' should be on a new line. 537
 Warning whitespace OperatorWrap '+' should be on a new line. 543
 Warning whitespace OperatorWrap '+' should be on a new line. 544
 Warning whitespace OperatorWrap '+' should be on a new line. 549
 Warning indentation Indentation 'if rcurly' have incorrect indentation level 17, expected level should be 16. 552
 Warning sizes LineLength Line is longer than 120 characters (found 121). 570
 Warning naming ParameterName Parameter name 'c' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 570
 Warning whitespace OperatorWrap '+' should be on a new line. 579
 Warning sizes LineLength Line is longer than 120 characters (found 122). 602
 Warning whitespace WhitespaceAround WhitespaceAround: 'synchronized' is not followed by whitespace. 603
 Warning naming LocalVariableName Local variable name 'r' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 608
 Warning naming LocalVariableName Local variable name 'c' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 613

org/opendaylight/topology/mlmt/observer/MlmtDataChangeEventListener.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.DataChangeListener' import. 12
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.DataBroker' import. 14
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yangtools.yang.binding.DataObject' import. 17
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.topology.mlmt.utility.MlmtDataChangeObserver' import. 20
 Warning javadoc JavadocMethod Missing a Javadoc comment. 31
 Warning javadoc JavadocMethod Missing a Javadoc comment. 39

org/opendaylight/topology/mlmt/observer/MlmtTopologyObserver.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.ArrayList' import. 13
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.DataBroker' import. 16
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.topology.mlmt.factory.MlmtProviderFactoryImpl' import. 21
 Warning indentation Indentation 'class def rcurly' have incorrect indentation level 1, expected level should be 0. 71