FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is low

Effort is max

Summary

Classes Bugs Errors Missing Classes
35 15 0 0

Files

Class Bugs
org.opendaylight.topology.mlmt.observer.AbstractMlmtTopologyObserver 7
org.opendaylight.topology.mlmt.observer.AbstractMlmtTopologyObserver$MlmtDataChangeEventType 1
org.opendaylight.topology.mlmt.observer.MlmtTopologyObserver 1
org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.MlmtTopologyObserverRuntimeRegistration 1
org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.modules.module.configuration.MlmtTopologyObserverImplBuilder$MlmtTopologyObserverImplImpl 1
org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.modules.module.configuration.mlmt.topology.observer.impl.DataBrokerBuilder$DataBrokerImpl 1
org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.modules.module.configuration.mlmt.topology.observer.impl.NotificationServiceBuilder$NotificationServiceImpl 1
org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.modules.module.configuration.mlmt.topology.observer.impl.RpcRegistryBuilder$RpcRegistryImpl 1
org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.modules.module.state.MlmtTopologyObserverImplBuilder$MlmtTopologyObserverImplImpl 1

org.opendaylight.topology.mlmt.observer.AbstractMlmtTopologyObserver

Bug Category Details Line Priority
org.opendaylight.topology.mlmt.observer.AbstractMlmtTopologyObserver.onMlmtTopologyCreated(LogicalDatastoreType, InstanceIdentifier, Topology) invokes inefficient new String(String) constructor PERFORMANCE DM_STRING_CTOR 198 Medium
org.opendaylight.topology.mlmt.observer.AbstractMlmtTopologyObserver.onMlmtTopologyCreated(LogicalDatastoreType, InstanceIdentifier, Topology) invokes toString() method on a String PERFORMANCE DM_STRING_TOSTRING 194 Low
org.opendaylight.topology.mlmt.observer.AbstractMlmtTopologyObserver.MLMT should be package protected MALICIOUS_CODE MS_PKGPROTECT 67 Medium
Redundant nullcheck of d, which is known to be non-null in org.opendaylight.topology.mlmt.observer.AbstractMlmtTopologyObserver.dumpMap(Map, AbstractMlmtTopologyObserver$MlmtDataChangeEventType) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 430 Low
org.opendaylight.topology.mlmt.observer.AbstractMlmtTopologyObserver.dumpMap(Map, AbstractMlmtTopologyObserver$MlmtDataChangeEventType) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 429 Medium
org.opendaylight.topology.mlmt.observer.AbstractMlmtTopologyObserver.handleCreatedData(LogicalDatastoreType, Map, AbstractMlmtTopologyObserver$MlmtDataChangeEventType) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 459 Medium
org.opendaylight.topology.mlmt.observer.AbstractMlmtTopologyObserver.handleUpdatedData(LogicalDatastoreType, Map, AbstractMlmtTopologyObserver$MlmtDataChangeEventType) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 525 Medium

org.opendaylight.topology.mlmt.observer.AbstractMlmtTopologyObserver$MlmtDataChangeEventType

Bug Category Details Line Priority
org.opendaylight.topology.mlmt.observer.AbstractMlmtTopologyObserver$MlmtDataChangeEventType.toString() may return null BAD_PRACTICE NP_TOSTRING_COULD_RETURN_NULL 83 Medium

org.opendaylight.topology.mlmt.observer.MlmtTopologyObserver

Bug Category Details Line Priority
Write to static field org.opendaylight.topology.mlmt.observer.AbstractMlmtTopologyObserver.MLMT from instance method org.opendaylight.topology.mlmt.observer.MlmtTopologyObserver.init(DataBroker, RpcProviderRegistry, String, List) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 42 Medium

org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.MlmtTopologyObserverRuntimeRegistration

Bug Category Details Line Priority
Unread field: org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.MlmtTopologyObserverRuntimeRegistration.unkeyedMap PERFORMANCE URF_UNREAD_FIELD 3 Low

org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.modules.module.configuration.MlmtTopologyObserverImplBuilder$MlmtTopologyObserverImplImpl

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.modules.module.configuration.MlmtTopologyObserverImplBuilder$MlmtTopologyObserverImplImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.modules.module.configuration.MlmtTopologyObserverImplBuilder$MlmtTopologyObserverImplImpl.equals(Object) STYLE BC_UNCONFIRMED_CAST 210 Low

org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.modules.module.configuration.mlmt.topology.observer.impl.DataBrokerBuilder$DataBrokerImpl

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.modules.module.configuration.mlmt.topology.observer.impl.DataBrokerBuilder$DataBrokerImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.modules.module.configuration.mlmt.topology.observer.impl.DataBrokerBuilder$DataBrokerImpl.equals(Object) STYLE BC_UNCONFIRMED_CAST 211 Low

org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.modules.module.configuration.mlmt.topology.observer.impl.NotificationServiceBuilder$NotificationServiceImpl

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.modules.module.configuration.mlmt.topology.observer.impl.NotificationServiceBuilder$NotificationServiceImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.modules.module.configuration.mlmt.topology.observer.impl.NotificationServiceBuilder$NotificationServiceImpl.equals(Object) STYLE BC_UNCONFIRMED_CAST 211 Low

org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.modules.module.configuration.mlmt.topology.observer.impl.RpcRegistryBuilder$RpcRegistryImpl

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.modules.module.configuration.mlmt.topology.observer.impl.RpcRegistryBuilder$RpcRegistryImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.modules.module.configuration.mlmt.topology.observer.impl.RpcRegistryBuilder$RpcRegistryImpl.equals(Object) STYLE BC_UNCONFIRMED_CAST 211 Low

org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.modules.module.state.MlmtTopologyObserverImplBuilder$MlmtTopologyObserverImplImpl

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.modules.module.state.MlmtTopologyObserverImplBuilder$MlmtTopologyObserverImplImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.topology.mlmt.topology.observer.impl.rev150122.modules.module.state.MlmtTopologyObserverImplBuilder$MlmtTopologyObserverImplImpl.equals(Object) STYLE BC_UNCONFIRMED_CAST 141 Low